Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: Remove --select in block command #2060

Merged
merged 1 commit into from
Aug 22, 2018
Merged

R4R: Remove --select in block command #2060

merged 1 commit into from
Aug 22, 2018

Conversation

mslipper
Copy link
Contributor

@mslipper mslipper commented Aug 16, 2018 •
edited by alexanderbez
Loading

Closes #1968.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Updated all relevant documentation (docs/)
  • Updated all relevant code comments
  • Wrote tests
  • Added entries in PENDING.md that include links to the relevant issue or PR that most accurately describes the change.
  • Updated cmd/gaia and examples/

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mslipper mslipper force-pushed the issue-1968 branch 3 times, most recently from e97481d to 6b8e0ed Compare August 16, 2018 07:34
@mslipper
Copy link
Contributor Author

I saw a TODO that said 'actually honor --select' that I removed... I suggest we instead track that in a GitHub issue as opposed to a TODO comment. I'm also happy to implement that if that'll be more valuable than this PR, just let me know.

@codecov
Copy link

codecov bot commented Aug 16, 2018 •
edited
Loading

Codecov Report

Merging #2060 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2060   +/-   ##
========================================
  Coverage    63.83%   63.83%           
========================================
  Files          113      113           
  Lines         6684     6684           
========================================
  Hits          4267     4267           
  Misses        2133     2133           
  Partials       284      284

alexanderbez
alexanderbez approved these changes Aug 16, 2018
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK -- I suggest creating a new issue and reference that here (for honoring --select 👍

cwgoes
cwgoes previously requested changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; please rebase against develop and check the CI failures.

@jackzampolin jackzampolin changed the title Remove --select in block command R4R: Remove --select in block command Aug 21, 2018
@jaekwon
Copy link
Contributor

jaekwon commented Aug 21, 2018

LGTM

@rigelrozanski rigelrozanski merged commit 3413a2b into cosmos:develop Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@cwgoes cwgoes cwgoes left review comments

@ebuchman ebuchman Awaiting requested review from ebuchman

Assignees
No one assigned
Labels
C:CLI T: UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mslipper @jaekwon @alexanderbez @rigelrozanski @cwgoes